martinzink commented on code in PR #2081:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2081#discussion_r2924552557
##########
extensions/rocksdb-repos/DatabaseContentRepository.cpp:
##########
@@ -58,21 +58,51 @@ bool DatabaseContentRepository::initialize(const
std::shared_ptr<minifi::Configu
setCompactionPeriod(configuration);
- auto set_db_opts = [encrypted_env]
(minifi::internal::Writable<rocksdb::DBOptions>& db_opts) {
+ const auto cache_size =
configuration->get(Configure::nifi_dbcontent_optimize_for_small_db_cache_size).or_else([]
{ return std::make_optional<std::string>("8 MB"); })
+ | utils::andThen([](const auto& cache_size_str) -> std::optional<uint64_t>
{
+ return parsing::parseDataSize(cache_size_str) | utils::toOptional();
+ });
Review Comment:
good idea, [invalid
nifi.database.content.repository.optimize.for.small.db.cache.…](https://github.com/apache/nifi-minifi-cpp/pull/2081/commits/b80ec78eaf15429ecfe28c5ae9ddda70e30645b0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
