[
https://jira.codehaus.org/browse/MNG-5702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=360484#comment-360484
]
Michael Osipov commented on MNG-5702:
-------------------------------------
First of all, we need to know why the {{IdentityHashMap}} was chosen, probably
on purpose. Second, what are you trying to achieve with your patch? Fix
concurrency issues? The proposed fix with {{Collections.synchronizedMap(new
IdentityHashMap(...))}} won't solve the problem because that wrapped map still
requires some synchronization with a monitor. See
[here|http://docs.oracle.com/javase/6/docs/api/java/util/Collections.html#synchronizedMap(java.util.Map)].
> Wrong reactor summary output while using -T option
> --------------------------------------------------
>
> Key: MNG-5702
> URL: https://jira.codehaus.org/browse/MNG-5702
> Project: Maven
> Issue Type: Bug
> Components: Reactor and workspace
> Affects Versions: 3.0.5, 3.1.1, 3.2.1, 3.2.2, 3.2.3, 3.2.5
> Reporter: Karl-Heinz Marbaise
> Assignee: Karl-Heinz Marbaise
> Priority: Minor
> Fix For: 3.2.6
>
>
> During some tests about an issue i found the following thing...
> {{mvn -T10 clean package}} and the output looks like this:
> {code}
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] project ............................................ SUCCESS [ 1.039
> s]
> [INFO] project1 ........................................... SUCCESS [ 1.066
> s]
> [INFO] project2 ........................................... SUCCESS [ 1.066
> s]
> [INFO] project3 ........................................... SUCCESS [ 1.067
> s]
> [INFO] project4 ........................................... SKIPPED
> [INFO] project5 ........................................... SUCCESS [ 1.066
> s]
> [INFO] project6 ........................................... SUCCESS [ 1.067
> s]
> [INFO] project7 ........................................... SUCCESS [ 1.067
> s]
> [INFO] project8 ........................................... SUCCESS [ 1.067
> s]
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 2.567 s (Wall Clock)
> [INFO] Finished at: 2014-10-18T21:10:15+02:00
> [INFO] Final Memory: 27M/345M
> [INFO]
> ------------------------------------------------------------------------
> {code}
> Based on the above output i would assume that the build has been wrong for
> some reason but if i take a look on the previous output:
> {code}
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ project2 ---
> [INFO]
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ project5 ---
> [INFO]
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ project8 ---
> [INFO]
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ project1 ---
> [INFO] Building jar:
> /Users/kama/ws-git/apache/massembly/massembly-684/project1/target/project1-1.0.0-SNAPSHOT.jar
> [INFO] Building jar:
> /Users/kama/ws-git/apache/massembly/massembly-684/project8/target/project8-1.0.0-SNAPSHOT.jar
> [INFO] Building jar:
> /Users/kama/ws-git/apache/massembly/massembly-684/project7/target/project7-1.0.0-SNAPSHOT.jar
> [INFO] Building jar:
> /Users/kama/ws-git/apache/massembly/massembly-684/project6/target/project6-1.0.0-SNAPSHOT.jar
> [INFO] Building jar:
> /Users/kama/ws-git/apache/massembly/massembly-684/project5/target/project5-1.0.0-SNAPSHOT.jar
> [INFO] Building jar:
> /Users/kama/ws-git/apache/massembly/massembly-684/project2/target/project2-1.0.0-SNAPSHOT.jar
> [INFO] Building jar:
> /Users/kama/ws-git/apache/massembly/massembly-684/project3/target/project3-1.0.0-SNAPSHOT.jar
> [INFO] Building jar:
> /Users/kama/ws-git/apache/massembly/massembly-684/project4/target/project4-1.0.0-SNAPSHOT.jar
> [INFO]
> [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @
> project7 ---
> [INFO]
> [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @
> project1 ---
> [INFO]
> [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @
> project5 ---
> [INFO]
> [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @
> project8 ---
> [INFO]
> [INFO]
> [INFO] --- maven-assembly-plugin:2.4.2-SNAPSHOT:single (make-assembly) @
> project1 ---
> [INFO]
> [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @
> project3 ---
> [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @
> project2 ---
> [INFO]
> [INFO] --- maven-assembly-plugin:2.4.2-SNAPSHOT:single (make-assembly) @
> project5 ---
> [INFO]
> [INFO] --- maven-assembly-plugin:2.4.2-SNAPSHOT:single (make-assembly) @
> project7 ---
> [INFO]
> [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @
> project4 ---
> [INFO]
> [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @
> project6 ---
> [INFO]
> [INFO] --- maven-assembly-plugin:2.4.2-SNAPSHOT:single (make-assembly) @
> project8 ---
> [INFO]
> [INFO] --- maven-assembly-plugin:2.4.2-SNAPSHOT:single (make-assembly) @
> project6 ---
> [INFO]
> [INFO] --- maven-assembly-plugin:2.4.2-SNAPSHOT:single (make-assembly) @
> project4 ---
> [INFO]
> [INFO]
> [INFO] --- maven-assembly-plugin:2.4.2-SNAPSHOT:single (make-assembly) @
> project2 ---
> [INFO] --- maven-assembly-plugin:2.4.2-SNAPSHOT:single (make-assembly) @
> project3 ---
> [INFO] Reading assembly descriptor: src/assembly/src-zip-only-assembly.xml
> [INFO] Reading assembly descriptor: src/assembly/src-zip-only-assembly.xml
> [INFO] Reading assembly descriptor: src/assembly/src-zip-only-assembly.xml
> [INFO] Reading assembly descriptor: src/assembly/src-zip-only-assembly.xml
> [INFO] Reading assembly descriptor: src/assembly/src-zip-only-assembly.xml
> [INFO] Reading assembly descriptor: src/assembly/src-zip-only-assembly.xml
> [INFO] Reading assembly descriptor: src/assembly/src-zip-only-assembly.xml
> [INFO] Reading assembly descriptor: src/assembly/src-zip-only-assembly.xml
> [INFO] Building zip:
> /Users/kama/ws-git/apache/massembly/massembly-684/project5/target/project5-1.0.0-SNAPSHOT-src.zip
> [INFO] Building zip:
> /Users/kama/ws-git/apache/massembly/massembly-684/project7/target/project7-1.0.0-SNAPSHOT-src.zip
> [INFO] Building zip:
> /Users/kama/ws-git/apache/massembly/massembly-684/project2/target/project2-1.0.0-SNAPSHOT-src.zip
> [INFO] Building zip:
> /Users/kama/ws-git/apache/massembly/massembly-684/project8/target/project8-1.0.0-SNAPSHOT-src.zip
> [INFO] Building zip:
> /Users/kama/ws-git/apache/massembly/massembly-684/project1/target/project1-1.0.0-SNAPSHOT-src.zip
> [INFO] Building zip:
> /Users/kama/ws-git/apache/massembly/massembly-684/project3/target/project3-1.0.0-SNAPSHOT-src.zip
> [INFO] Building zip:
> /Users/kama/ws-git/apache/massembly/massembly-684/project4/target/project4-1.0.0-SNAPSHOT-src.zip
> [INFO] Building zip:
> /Users/kama/ws-git/apache/massembly/massembly-684/project6/target/project6-1.0.0-SNAPSHOT-src.zip
> [INFO]
> ------------------------------------------------------------------------
> {code}
> I can see that all projects have been sucessfully packaged. So from my point
> of view this looks like a problem in the reactor summary output...
> Furthermore the wrongly stated projects changes from run to run...
> I have used the following project
> https://github.com/khmarbaise/massembly/tree/master/massembly-684 to create
> those output and done the tests with it.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
