[ 
https://jira.codehaus.org/browse/SUREFIRE-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=359634#comment-359634
 ] 

Tibor Digana edited comment on SUREFIRE-1128 at 12/24/14 7:36 PM:
------------------------------------------------------------------

In the entire code we use animal-sniffer-maven-plugin with signature java15 in 
src/main/java code.
This means the surefire project is built correctly with code base 1.5, whatever 
Maven dist 2.2.1/3.x is used.

Regarding IT(jetty-war-test-failing) Unsupported major.minor version 51.0 [J2SE 
7 = 51 (0x33 hex)], this failure appears due to ${java.home} refers to JDK5. 

Due to these problems, we should use JUnit assumptions in beginning of IT which 
only ignores the tests for JDK < 7:

<org.hamcrest:hamcrest-library:1.3:test>
import static org.hamcrest.Matchers.*;

assumeThat( jvmMajor, is( 1 ) )
assumeThat( jvmMinor, is( greaterThanOrEqualTo( 7 ) ) )

Because of these tests require JDK 7 and because of no-test-avoidance, we 
should state in README.txt that JDK 7 is preferable in order to get bigger test 
coverage.




was (Author: tibor17):
In the entire code we use animal-sniffer-maven-plugin with signature java15 in 
src/main/java code.
This means the surefire project is built correctly with code base 1.5, whatever 
Maven dist 2.2.1/3.x is used.

Regarding IT(jetty-war-test-failing) Unsupported major.minor version 51.0 [J2SE 
7 = 51 (0x33 hex)], this failure appears due to ${java.home} refers to JDK5. 

Due to these problems, we should use JUnit assumptions in beginning of IT test 
which only ignores the tests for JDK < 7:

assumeThat( jvmMajor, is( 1 ) )
assumeThat( jvmMinor, is( greaterThanOrEqualTo( 7 ) ) )

Because of these tests require JDK 7 and because of no-test-avoidance, we 
should state in README.txt that JDK 7 is preferable in order to get bigger test 
coverage.



> Fix mvn 2.2.1 build process 
> https://builds.apache.org/view/All/job/maven-surefire-mvn-2.2.1
> -------------------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-1128
>                 URL: https://jira.codehaus.org/browse/SUREFIRE-1128
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Failsafe Plugin, Maven Surefire Plugin, Maven 
> Surefire Report Plugin
>    Affects Versions: 2.18
>         Environment: 
> https://builds.apache.org/view/All/job/maven-surefire-mvn-2.2.1
>            Reporter: Tibor Digana
>             Fix For: 2.19
>
>
> Fix OOM: MaxPermSize, IT(jetty-war-test-failing) Unsupported major.minor
> version 51.0



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Reply via email to