[ 
https://jira.codehaus.org/browse/MCHECKSTYLE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher Tubbs closed MCHECKSTYLE-269.
-----------------------------------------

    Resolution: Not A Bug

Closing this. Unfortunately, I had not realized that some checkstyle rules need 
to run on compiled class files to verify subclasses. {{JavadocMethod}} appears 
to be one of them, otherwise it spits out {{JavadocMethod: Unable to get class 
information for @throws tag}} messages.

Given that information, it does make sense that the plugin runs at verify by 
default, since there's no "validate after compile" phase of the build lifecycle.

> Style should be checked during validate, not verify
> ---------------------------------------------------
>
>                 Key: MCHECKSTYLE-269
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-269
>             Project: Maven Checkstyle Plugin
>          Issue Type: Improvement
>          Components: checkstyle:check
>            Reporter: Christopher Tubbs
>
> The style check currently runs by default at the verify phase of the build 
> lifecycle.
> That is far too late. It should run on the code in the SCM, during the 
> validate phase, before any generated sources/resources are created during the 
> build, before tests and integration tests (which can take a long time).
> If there's a bad style, it should be noticed immediately. The validate phase 
> of the Maven build lifecycle is the most appropriate phase for this.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Reply via email to