[
https://jira.codehaus.org/browse/MSKINS-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=359536#comment-359536
]
Michael Osipov commented on MSKINS-94:
--------------------------------------
Tobias, I have evaluated you report and there is a two-fold problem:
1. The mojo site is not handwritten but autogenerated and the generator isn't
really good. It uses HTML tags which aren't appropriate in many cases.
2. Let's take another example for a fluido-based site:
http://dirctxsrc.sourceforge.net/dircontextsourcefactory.html open up Firefox'
CSS editor and disable the margins on the P and DT elements. You'll see that
the text is not indented under the headline elements. That would be the outcome
of the change.
I do not think that this change is good but rather the plugin mojo to HTML
generator is faulty.
What do you think?
> Left margin on p elements leads to rugged indentation
> -----------------------------------------------------
>
> Key: MSKINS-94
> URL: https://jira.codehaus.org/browse/MSKINS-94
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
> Environment: maven-fluido-skin 1.3.1
> Reporter: Tobias Oberlies
>
> The {{margin-left}} on {{p}} elements in the Fluido skin leads to a rugged
> indentation, and there is no way to avoid it in a typical Mojo site doc page.
> Consider for example the
> [test-mojo|http://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html]
> page: On this page, each of the parameter descriptions is not enclosed in
> {{p}} elements. In the overview table this leads to a proper alignment with
> the "User property" and "Default value" lines because they are also not
> enclosed in paragraphs.
> In the "Parameter Details" section however, the parameter names are enclosed
> in {{p}} elements, making the parameter descriptions look as if they have a
> negative indentation.
> Enclosing the parameter descriptions in {{p}} elements (in the Mojo sources)
> would help for the parameter details section, but this then leads to a rugged
> indentation in the overview table.
> So, since it cannot be ensured that {{p}} elements are used everywhere,
> Fluido should not assing a left margin to them.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
