[jira] (MJAVADOC-368) Can not use a comma (,) in option additionalparam

[Kannan Goundan (JIRA)]

    [ 
https://jira.codehaus.org/browse/MJAVADOC-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=358666#comment-358666
 ] 

Kannan Goundan commented on MJAVADOC-368:
-----------------------------------------

I checked out the latest maven-javadoc-plugin source code and made the 
following single-line change:

{code}
Index: src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java
===================================================================
--- src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java      
(revision 1643233)
+++ src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java      
(working copy)
@@ -4617,7 +4617,7 @@

         addArgIf( arguments, verbose, "-verbose" );

-        addArgIfNotEmpty( arguments, null, additionalparam );
+        addArgIfNotEmpty( arguments, null, additionalparam, false, false );
     }

     /**
{code}

This fixed the issue for me.  Does this look good to merge upstream?

This is technically a breaking change, even though it's sort of a bug fix.  So 
maybe this warrants a version bump to 2.11?

> Can not use a comma (,) in option additionalparam
> -------------------------------------------------
>
>                 Key: MJAVADOC-368
>                 URL: https://jira.codehaus.org/browse/MJAVADOC-368
>             Project: Maven Javadoc Plugin
>          Issue Type: Bug
>    Affects Versions: 2.9
>            Reporter: Andy Schönemann
>
> I would like to set an additional parameter for javadoc like
> {{<additionalparam>-header &apos;A,B&apos;</additionalparam>}}
> But this is not possible! Every comma here separates the string into 
> different parameters. So I'm not able to set parameters including commas.
> Furthermore, the options name is {{additionalparam}} and NOT 
> {{additionalparamS}}. So it should not be possible to set multiple parameters 
> here.
> I also tried 
> {{<additionalparam>-header &apos;A&#44;B&apos;</additionalparam>}}
> but this doesn't work either.
> [Plugin 
> documentation|http://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#additionalparam]
>  



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)