[ 
https://jira.codehaus.org/browse/MPMD-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=358099#comment-358099
 ] 

Michael Osipov edited comment on MPMD-170 at 11/26/14 10:32 AM:
----------------------------------------------------------------

Fixed with [r1641834|http://svn.apache.org/r1641834].

Stevo, I have omitted the second part of your patch. Create another issue for 
that please.

Unfortunately, I cannot provide an IT for that because {{targetJdk}} is private 
and I cannot reasonably check whether the correct value has been injected or 
not.


was (Author: michael-o):
Fixed with [r1641834|http://svn.apache.org/r1641834].

Stevo, I have omitted the second part of your patch. Create another issue for 
that please.

> Have targetJdk default to maven.compiler.target
> -----------------------------------------------
>
>                 Key: MPMD-170
>                 URL: https://jira.codehaus.org/browse/MPMD-170
>             Project: Maven PMD Plugin
>          Issue Type: Improvement
>          Components: PMD
>    Affects Versions: 3.0.1
>            Reporter: Stevo Slavic
>            Assignee: Michael Osipov
>            Priority: Minor
>             Fix For: 3.4
>
>         Attachments: MPMD-170.patch
>
>
> Currently {{targetJdk}} has to be defined separately from 
> {{maven.compiler.target}} property that most plugins already default to, so 
> target JDK information is unnecessarily repeated, making POMs with 
> maven-pmd-plugin less DRY, harder to maintain, prone to mistakes and unwanted 
> behavior.
> So, please make {{targetJdk}} default to {{maven.compiler.target}} property.
> Attached is [^MPMD-170.patch] which adds this behavior.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Reply via email to