[ https://jira.codehaus.org/browse/SCM-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=349830#comment-349830 ]
Todd Currie commented on SCM-735: --------------------------------- Actually, on closer examination there is an additional defect with this patch. The annotate command has been switched to follow inherited changelists from branches (which is great), but the filelog has not also been changed. An additional "-i" argument should be added after filelog in the createFilelogCommandLine method of the PerforceBlameCommand. Otherwise, not all of the changes will match up between the two commands. > Blame result on branched file is incorrect > ------------------------------------------ > > Key: SCM-735 > URL: https://jira.codehaus.org/browse/SCM-735 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-perforce > Affects Versions: 1.8.1 > Reporter: Gregory SSI-YAN-KAI > Attachments: scm.patch > > > When a file is branched, its revision id restarts from 1. > So, 2 different lines can have the same revision id even though they have > been submitted in 2 different changelists. > Since the perforce blame command is based on the revision id of each line, > the result might be incorrect. > The solution I'm proposing in the attached patch is to use changelist number > to identify the author of a line. -- This message was sent by Atlassian JIRA (v6.1.6#6162)