[ https://jira.codehaus.org/browse/MNG-4597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict updated MNG-4597: ------------------------------- Fix Version/s: (was: Issues to be reviewed for 3.x) > FindBugs analysis effects > ------------------------- > > Key: MNG-4597 > URL: https://jira.codehaus.org/browse/MNG-4597 > Project: Maven > Issue Type: Bug > Affects Versions: 2.2.1 > Environment: n/a > Reporter: M Pazurkiewicz > Priority: Minor > > I've run a FindBugs analysis for the 2.2.1 sources. > I found a number of minor issues: > * lots of unread fields > * misleading class naming > (org.apache.maven.artifact.repository.metadata.RepositoryMetadataInstallationException > > and > org.apache.maven.artifact.repository.metadata.RepositoryMetadataDeploymentException > do not inherit from Exception class) > * using Number constructors instead of static valueOf (the latter is > significantly more efficient) > And as far as more serious issues: > In src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java > I found a curious self-assignment: > public void setSession( MavenSession session ) > { > session = session; > } -- This message was sent by Atlassian JIRA (v6.1.6#6162)