[
https://jira.codehaus.org/browse/MCHECKSTYLE-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=344370#comment-344370
]
Dennis Lundberg commented on MCHECKSTYLE-225:
---------------------------------------------
Having looked at it, I think that the implementation of the new
LicenseResourceManager is wrong. Lines 60-66:
{code:java}
if ( resourceLoader instanceof ThreadContextClasspathResourceLoader
&& !"config/maven-header.txt".equals( name ) )
{
// MCHECKSTYLE-219: Don't load the license from the plugin
// classloader, only allow config/maven-header.txt
continue;
}
{code}
Shouldn't it be:
{code:java}
if ( resourceLoader instanceof ThreadContextClasspathResourceLoader
&& "config/maven-header.txt".equals( name ) )
{
// MCHECKSTYLE-219: Don't load the license from the plugin
// classloader, only allow config/maven-header.txt
continue;
}
{code}
Robert, could you comment on that?
> headerLocation no longer sets checkstyle.header.file
> ----------------------------------------------------
>
> Key: MCHECKSTYLE-225
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-225
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
> Affects Versions: 2.12
> Environment: JDK 7u51 on OS X with Maven 3.1.0
> Reporter: Diwaker Gupta
>
> We use a multi-module configuration as described at
> https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/multi-module-config.html
> This morning I tried upgraded to checkstyle-plugin 2.12 and our builds
> started failing with:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-checkstyle-plugin:2.12:check (default-cli) on
> project common: Failed during checkstyle execution: Failed during checkstyle
> configuration: unable to read /path/to/common/target/checkstyle-checker.xml -
> unable to parse configuration stream - Property ${checkstyle.header.file} has
> not been set -> [Help 1]
> {noformat}
> Our config hasn't changed in almost two years. We are currently using v2.11
> so this seems like a regression in 2.12
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
