[ 
https://jira.codehaus.org/browse/MNG-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=340774#comment-340774
 ] 

Jason van Zyl edited comment on MNG-5479 at 2/6/14 9:06 PM:
------------------------------------------------------------

Milos, your way is simpler. Just applied your patch.


was (Author: jason):
Milos, you way is simpler. Just applied your patch.

> ExecutionEvent.Type.SessionEnded omited when runtime exception thrown
> ---------------------------------------------------------------------
>
>                 Key: MNG-5479
>                 URL: https://jira.codehaus.org/browse/MNG-5479
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: Embedding, IDEs
>    Affects Versions: 3.0.4, 3.0.5
>            Reporter: Milos Kleint
>            Assignee: Jason van Zyl
>             Fix For: 3.2
>
>         Attachments: maven.patch
>
>
> in LifecycleStarter.java the ExecutionEvent.Type.SessionStarted is always 
> fired, but ExecutionEvent.Type.SessionEnded appears only be fired when in 
> some cases, omitted in case of RuntimeException thrown. IMHO the event should 
> be fired in finally {} block. See attached patch.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Reply via email to