[ 
https://jira.codehaus.org/browse/MASSEMBLY-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=340228#comment-340228
 ] 

Paul Millar commented on MASSEMBLY-681:
---------------------------------------

If I've understood you correctly, maven mojo XML parser simply ignores empty 
elements.  If so, this sounds like a bug as an empty element is both valid and 
distinct from that element being missing.

To me, introducing a noFinalName flag looks like a work-around for this 
XML-parser bug.  As the problem isn't urgent (at least, for me), perhaps it 
would be better to fix the mojo XML parser so empty XML elements are not 
ignored.

> plugin ignores empty finalName and uses default value
> -----------------------------------------------------
>
>                 Key: MASSEMBLY-681
>                 URL: https://jira.codehaus.org/browse/MASSEMBLY-681
>             Project: Maven Assembly Plugin
>          Issue Type: Wish
>    Affects Versions: 2.4
>            Reporter: Paul Millar
>            Priority: Minor
>
> When used in the 'dir' format, I would argue that an empty finalName is 
> reasonable.
> For example, I would expect the following configuration, with the 'dir' 
> format, to output the assembled files in ${foo.baseDirectory}
>     <configuration>
>         <descriptors>
>           <descriptor>src/main/assembly/foo.xml</descriptor>
>         </descriptors>
>         <outputDirectory>${foo.baseDirectory}</outputDirectory>
>         <finalName/>
>     </configuration>
> The actual behaviour is to silently ignore the configured empty finalName and 
> use the default finalName value, which is append this to the outputDirectory.
> Arguably there are two bugs here:
>     finalName is silently ignored (if this is invalid, it should report an 
> error)
>     the empty finalName is not honoured.
> Specify '.' as the finalName (<finalName>.</finalName>) seems to work as a 
> work-around, at least for unix-like systems.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Reply via email to