[
https://jira.codehaus.org/browse/MENFORCER-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=328409#comment-328409
]
Mirko Friedenhagen edited comment on MENFORCER-159 at 1/20/14 11:54 PM:
------------------------------------------------------------------------
* LOL, sometimes a fluffy finger is sufficient, so this would the loving part
:-).
* You are right that this may be achieved with two execution blocks as well,
but this is the same for failsafe: most of the stuff failsafe does could be
done with surefire.
* Execution blocks with their IDs and their linkage to lifecycles are IMO more
complicated than having two different mojos which may even be invoked from the
CLI. And the messages are a bit different, see {{createRuleMessage}} :-)
was (Author: mfriedenhagen):
* LOL, sometimes a fluffy finger is sufficient, so this would the loving
part :-).
* You are right that this may be achieved with two execution blocks as well,
but this is the same for failsafe: most of the stuff failsafe does could be
done with surefire.
* Execution blocks with their IDs and their linkage to lifecycles are IMO more
complicated than having to different mojos which may even be invoked from the
CLI. And the messages are a bit different, see {{createRuleMessage}} :-)
> Add goal recommend which will only warn but never fail a build
> --------------------------------------------------------------
>
> Key: MENFORCER-159
> URL: https://jira.codehaus.org/browse/MENFORCER-159
> Project: Maven Enforcer Plugin
> Issue Type: New Feature
> Components: Plugin
> Affects Versions: 1.3
> Reporter: Mirko Friedenhagen
> Assignee: Robert Scholte
> Fix For: 2.0
>
> Attachments: recommend-mojo.patch
>
>
> In our company's parent POM we define a lot of rules, some of which are
> controversial or may not be easily fulfilled. The patch I attach defines a
> new goal "recommend" which will always warn but never fail. It's
> configuration is done by a new element {{recommendations}} which just holds a
> sequence of rules.
> I extracted most of EnforceMojo to AbstractEnforceMojo to avoid code
> duplication. I added an invoker test and all tests ran successfully.
> See https://github.com/apache/maven-enforcer/pull/4 as well for easier review.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
