[ 
https://jira.codehaus.org/browse/SUREFIRE-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=337758#comment-337758
 ] 

Andreas Gudian commented on SUREFIRE-1047:
------------------------------------------

Thanks for the pull request!

I've merged the current state to master.

What would be great would be to make it also work for the 
{{systemPropertyVariables}} section in the config (as [in the 
examples|http://maven.apache.org/surefire/maven-surefire-plugin/examples/system-properties.html]).
The fork-number replacing is currently done using 
{{AbstractSurefireMojo#createCopyAndReplaceForkNumPlaceholder}}, that would be 
a good place to start with that change. This would automatically enable system 
properties passed to maven via {{mvn test -DmyPro=\@\{evaluated-late\}}} to 
benefit from your feature.

What do think?
                
> Add @{...} property evaluation for the argLine
> ----------------------------------------------
>
>                 Key: SUREFIRE-1047
>                 URL: https://jira.codehaus.org/browse/SUREFIRE-1047
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: Maven Surefire Plugin
>    Affects Versions: 2.16
>            Reporter: Henning Schmiedehausen
>            Assignee: Andreas Gudian
>             Fix For: 2.17
>
>
> Replaces expressions @{property-name} in the argLine with the corresponding 
> properties from the model. This allows late evaluation of property values 
> when the plugin is executed (as compared to evaluation when the pom is parsed 
> as is done with ${property-name} expressions).
> This allows other plugins to modify or set properties with the changes
> getting picked up by surefire.
> Please merge the pull request at 
> https://github.com/apache/maven-surefire/pull/30

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to