[ 
https://jira.codehaus.org/browse/WAGON-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=337575#comment-337575
 ] 

Stuart McCulloch commented on WAGON-407:
----------------------------------------

My analysis:

Looks like a shading issue in maven-wagon/wagon-providers/wagon-http:

        
https://git-wip-us.apache.org/repos/asf?p=maven-wagon.git;a=blob;f=wagon-providers/wagon-http/pom.xml;h=1fd61e34da435024062a566f6bd68410d98fdc67;hb=HEAD#l87

It doesn?t shade in commons-io, commons-lang, or jsoup; despite 
wagon-http-shared switching from plexus-utils to commons-lang/io, and over to 
jsoup as the HTML parser:

        
https://git-wip-us.apache.org/repos/asf?p=maven-wagon.git;a=commit;h=ec65719a
        
https://git-wip-us.apache.org/repos/asf?p=maven-wagon.git;a=commit;h=02681881

        [INFO] --- maven-shade-plugin:1.4:shade (default) @ wagon-http ---
        [INFO] Excluding 
org.apache.maven.wagon:wagon-http-shared:jar:2.6-SNAPSHOT from the shaded jar.
        [INFO] Excluding org.jsoup:jsoup:jar:1.7.2 from the shaded jar.
        [INFO] Excluding commons-lang:commons-lang:jar:2.6 from the shaded jar.
        [INFO] Excluding commons-io:commons-io:jar:2.2 from the shaded jar.
        [INFO] Including org.apache.httpcomponents:httpclient:jar:4.3.1 in the 
shaded jar.
        [INFO] Including commons-codec:commons-codec:jar:1.6 in the shaded jar.
        [INFO] Including commons-logging:commons-logging:jar:1.1.3 in the 
shaded jar.
        [INFO] Including org.apache.httpcomponents:httpcore:jar:4.3 in the 
shaded jar.
        [INFO] Excluding 
org.apache.maven.wagon:wagon-provider-api:jar:2.6-SNAPSHOT from the shaded jar.
        [INFO] Excluding org.codehaus.plexus:plexus-utils:jar:3.0.8 from the 
shaded jar.
        [INFO] Attaching shaded artefact.

It might be less fragile to just exclude unwanted dependencies in the 
wagon-http shade configuration, rather than have to keep the list of includes 
in sync?

As to why the IT passes with M2 but fails with M3... wagon-http is included in 
the distribution lib (uber jar for M2, separate jar for M3) so M2 is using an 
older version of wagon that doesn?t suffer from the above issue.

(NOTE: adding commons-io, commons-lang, and jsoup jars to the M3 distribution 
lib is a workaround for this issue)
                
> Wagon ITs fail with missing class: org.apache.commons.io.IOUtils
> ----------------------------------------------------------------
>
>                 Key: WAGON-407
>                 URL: https://jira.codehaus.org/browse/WAGON-407
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-http
>            Reporter: Stuart McCulloch
>
> See http://www.mail-archive.com/[email protected]/msg132210.html thread

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to