[ 
https://jira.codehaus.org/browse/MSHADE-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=332379#comment-332379
 ] 

Richard Sand commented on MSHADE-154:
-------------------------------------

I also submitted a patch for MSHADE-139, so added a second patch file here with 
both my 139 and 154 changes. Thanks!
                
> Add ability for shade to find primary artifact from attached artifacts 
> (similar to assembly-plugin)
> ---------------------------------------------------------------------------------------------------
>
>                 Key: MSHADE-154
>                 URL: https://jira.codehaus.org/browse/MSHADE-154
>             Project: Maven Shade Plugin
>          Issue Type: New Feature
>    Affects Versions: 2.0
>         Environment: all
>            Reporter: Richard Sand
>         Attachments: patch139and154.txt, patch.txt
>
>
> When switching from assembly-plugin to shade-plugin for a given project, I 
> discovered that the shade plugin did not have the capability of using an 
> attached artifact as the primary artifact - only the project's main artifact 
> was supported.
> I've attached changes to add a configuration parameter 
> "alternativeInputClassifier", which, when specified, tells the plugin to look 
> for an artifact with the specified classifier in the project attachments, and 
> to use that as the primary artifact. This makes shade behave similar to 
> assembly-plugin, and allows shade to recognize attached artifacts generated 
> by previous plugins in a maven execution.
> This was a trivial change, but required modifying several other classes and 
> methods to accept the "primary" artifact as a parameter instead of a global 
> variable. IMHO these changes are good for the plugin as a whole, as it will 
> allow for future flexibility and logic for determining the entrypoint for the 
> plugin (e.g. being able to run as a standalone goal with a specific artifact 
> as input).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to