[ 
https://jira.codehaus.org/browse/MENFORCER-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=328067#comment-328067
 ] 

Robert Scholte commented on MENFORCER-157:
------------------------------------------

[~sebbASF], I know you're trying to improve the quality of the distributions. 
However, the quality of this issue is comparable with the average first issue 
done by a new Maven user: right now it reads as an opinion/unfunded complaint. 
(new users shouldn't be offended, since the more issues they file, the better 
they understand what we need, e.g. reproducability )
It would help if you either: 
- refer to a page which states what is and is not allowed in the NOTICE file.
- provide a patch. Since you have a good idea how the NOTICE should look like 
and you seem to have checked out the sources it should be quite easy to make 
such a patch. This prevents the start of maybe an unnecessary discussion, which 
would be a waste of time if the patch shows the improvement.
                
> NOTICE file bad indentation & references software which is not actually 
> included
> --------------------------------------------------------------------------------
>
>                 Key: MENFORCER-157
>                 URL: https://jira.codehaus.org/browse/MENFORCER-157
>             Project: Maven 2.x Enforcer Plugin
>          Issue Type: Bug
>            Reporter: SebbASF
>
> The NOTICE file says:
> {noformat}
> Apache Maven Enforcer Plugin
>    Copyright 1999-2013 The Apache Software Foundation
>    This product includes software developed at
>    The Apache Software Foundation (http://www.apache.org/).
>    
>    Portions of this software utilize the Plexus Container, API, and
>    Components.  Copyright the Codehaus. The original software is
>    available from http://plexus.codehaus.org/
> {noformat}
> The lines should all start in column 1
> The last paragraph refers to software that is not actually included in the 
> source release (nor the binary release, AFAIK). The NOTICE file needs to 
> relate to the actual contents of the release and must contain required 
> notices only. I think it should be removed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to