Rich DiCroce created SCM-721:
--------------------------------

             Summary: Mercurial ChangeLog command doesn't respect limit
                 Key: SCM-721
                 URL: https://jira.codehaus.org/browse/SCM-721
             Project: Maven SCM
          Issue Type: Bug
          Components: maven-scm-provider-mercurial (hg)
    Affects Versions: 1.8.1
            Reporter: Rich DiCroce


The changeLog() method does not respect the limit parameter. This appears to 
happen because the limit parameter gets lost in the middle of the method chain:
1. HgScmProvider.changelog() calls AbstractCommand.execute()
2. AbstractCommand.execute() calls AbstractChangeLogCommand.executeCommand()
3. AbstractChangeLogCommand.executeCommand() calls one of two overloads of 
executeChangeLogCommand(), both of which are deprecated. Neither takes a limit 
parameter, and the limit parameter is lost at this point.

I encountered this problem on Mercurial, but other providers will also be 
affected unless their concrete ChangeLogCommand implementations override 
executeCommand() to call a method that supports the limit parameter. Curiously, 
HgChangeLogCommand does have such a method, but it is never called.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to