[ 
https://jira.codehaus.org/browse/MCHECKSTYLE-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=320479#comment-320479
 ] 

Michael Heuer commented on MCHECKSTYLE-189:
-------------------------------------------

Tar via cygwin should work on windows.

The problem is in fact with a custom configuration checkstyle.xml which 
includes 
{code:xml}
<module name="DoubleCheckedLocking"/>
{code}

The release notes for Checkstyle 5.5 --> 5.6 say

bq. Removed the DoubleCheckedLocking check, as in Java 5 (and beyond), using 
the volatile keyword addresses the issue. See here for more details.

The release notes for Maven Checkstyle Plugin 2.9.1 --> 2.10 do not mention 
this change.

I think both projects have failed with regards to semantic versioning -- even 
though this is not a strict binary-incompatible change, it is a 
configuration-incompatible change.  Updating a minor version of a maven plugin 
should not cause existing projects to break.
                
> Unable to instantiate DoubleCheckedLockingCheck exception after upgrading 
> from version 2.9.1 to 2.10
> ----------------------------------------------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-189
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-189
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.10
>         Environment: $ mvn -v
> Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 
> 07:51:28-0600)
> Maven home: /Users/mheuer/bin/maven-latest
> Java version: 1.6.0_37, vendor: Apple Inc.
> Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
> Default locale: en_US, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.5", arch: "x86_64", family: "mac" 
>            Reporter: Michael Heuer
>         Attachments: mcheckstyle188.tar.gz
>
>
> After upgrading from version 3.9.1 to version 3.10
> $ mvn -e site
> ...
> Error during page generation: Error rendering Maven report: Failed during 
> checkstyle configuration: cannot initialize module TreeWalker - Unable to 
> instantiate DoubleCheckedLocking: Unable to instantiate 
> DoubleCheckedLockingCheck -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-site-plugin:3.2:site (default-site) on 
> project dsh-midi-cytoscape3-app: Error during page generation
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error during page 
> generation
> at org.apache.maven.plugins.site.SiteMojo.execute(SiteMojo.java:143)
> at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
> ... 19 more
> Caused by: org.apache.maven.doxia.siterenderer.RendererException: Error 
> rendering Maven report: Failed during checkstyle configuration
> at 
> org.apache.maven.plugins.site.ReportDocumentRenderer.renderDocument(ReportDocumentRenderer.java:233)
> at 
> org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderModule(DefaultSiteRenderer.java:319)
> at 
> org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:135)
> at org.apache.maven.plugins.site.SiteMojo.renderLocale(SiteMojo.java:175)
> at org.apache.maven.plugins.site.SiteMojo.execute(SiteMojo.java:138)
> ... 21 more
> Caused by: org.apache.maven.reporting.MavenReportException: Failed during 
> checkstyle configuration
> at 
> org.apache.maven.plugin.checkstyle.AbstractCheckstyleReport.executeReport(AbstractCheckstyleReport.java:260)
> at 
> org.apache.maven.plugin.checkstyle.CheckstyleReport.executeReport(CheckstyleReport.java:339)
> at 
> org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:196)
> at 
> org.apache.maven.plugins.site.ReportDocumentRenderer.renderDocument(ReportDocumentRenderer.java:219)
> ... 25 more
> Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: cannot 
> initialize module TreeWalker - Unable to instantiate DoubleCheckedLocking
> at com.puppycrawl.tools.checkstyle.Checker.setupChild(Checker.java:178)
> at 
> com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure(AutomaticBean.java:184)
> at 
> org.apache.maven.plugin.checkstyle.DefaultCheckstyleExecutor.executeCheckstyle(DefaultCheckstyleExecutor.java:172)
> at 
> org.apache.maven.plugin.checkstyle.AbstractCheckstyleReport.executeReport(AbstractCheckstyleReport.java:245)
> ... 28 more
> Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: Unable to 
> instantiate DoubleCheckedLocking
> at 
> com.puppycrawl.tools.checkstyle.PackageObjectFactory.createModule(PackageObjectFactory.java:155)
> at com.puppycrawl.tools.checkstyle.TreeWalker.setupChild(TreeWalker.java:161)
> at 
> com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure(AutomaticBean.java:184)
> at com.puppycrawl.tools.checkstyle.Checker.setupChild(Checker.java:157)
> ... 31 more
> Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: Unable to 
> instantiate DoubleCheckedLockingCheck
> at 
> com.puppycrawl.tools.checkstyle.PackageObjectFactory.doMakeObject(PackageObjectFactory.java:98)
> at 
> com.puppycrawl.tools.checkstyle.PackageObjectFactory.createModule(PackageObjectFactory.java:152)
> ... 34 more

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to