[ 
https://jira.codehaus.org/browse/MCOMPILER-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=318901#comment-318901
 ] 

Jan Sievers commented on MCOMPILER-178:
---------------------------------------

IMHO the existing mojo parameters String compilerArgument and Map 
compilerArguments can't be modified in a backwards-compatible way to support 
both multiple arguments and characters not allowed in XML element names.
At the same time there are all kinds of shortcomings with the current map-based 
approach (":" in arguments being interpreted as XML namespace separators, "+" 
not allowed in XML element names, fixed -key=value syntax, etc...) and these 
are real-world problems with compiler arguments of the eclipse JDT compiler[1].
Another recent example which shows that the current approach doesn't scale is 
the fix for MCOMPILER-135 : special handling had to be introduced for the 
"-Akey=value" syntax.

I propose to fix this by introducing a new List mojo parameter e.g. 
"compilerArgs" and deprecate the old Map compilerArguments.
Here is my pull request:
https://github.com/apache/maven-plugins/pull/4

BTW we fixed this for tycho in a similar way [2]

[1] 
http://help.eclipse.org/juno/index.jsp?topic=%2Forg.eclipse.jdt.doc.user%2Ftasks%2Ftask-using_batch_compiler.htm
[2] https://git.eclipse.org/r/#/c/10254/
                
> can't specify -Xlint:-path option without violation of XML well-formness
> ------------------------------------------------------------------------
>
>                 Key: MCOMPILER-178
>                 URL: https://jira.codehaus.org/browse/MCOMPILER-178
>             Project: Maven 2.x Compiler Plugin
>          Issue Type: Bug
>            Reporter: Yegor Bugayenko
>
> This XML document is not valid:
> {noformat}
> <compilerArguments>
>   <Xlint:-path/>
> </compilerArguments>
> {noformat}
> because {{Xlint}} is interpreted as a namespace, which is absent in the 
> document

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to