[ 
https://jira.codehaus.org/browse/MSHARED-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=312868#comment-312868
 ] 

Jörg Schaible commented on MSHARED-258:
---------------------------------------

Facts in short: Null character encoding is always illegal in XML. Control 
characters encodings are illegal in  XML 1.0, but valid in XML 1.1 (simply 
write appropriate XML header).

Long story: Jason used ages ago the code for Xpp3Dom in XStream and took the 
PrettyPrintWriter also in Plexus. The code evolved in XStream also over the 
years though ;-)

See special note and linked XML specs in 
http://xstream.codehaus.org/javadoc/com/thoughtworks/xstream/io/xml/PrettyPrintWriter.html
                
> PrettyPrintXmlWriter encoding of \u0000 in xpp3dom attribute 
> incorrect/different from p-u xpp3dom
> -------------------------------------------------------------------------------------------------
>
>                 Key: MSHARED-258
>                 URL: https://jira.codehaus.org/browse/MSHARED-258
>             Project: Maven Shared Components
>          Issue Type: Bug
>          Components: maven-shared-utils
>    Affects Versions: maven-shared-utils-0.1
>            Reporter: Kristian Rosenvold
>
> When porting surefire to m-s-u I came across the case where
> unicode \u0000 gets encoded as � in an xml attribute in the 
> prettyprintxmlwriter. This is probably the reason why the 
> PrettyPrintXmlWriter was forked into surefire originally. 
> Now from SUREFIRE-456 it seems like it's specification-wise illegal to do 
> this encoding, but it does actually preserve the character value of 
> non-printable characters. 
> So the more I type on this issue, the more it seems like the forked PPXW 
> actually does the best-effort "right" thing when it comes to xml encoding 
> "any" string as long as we want to stay human readable....?
> I need some input on this one ;)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to