[ 
https://jira.codehaus.org/browse/MJAVADOC-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=308561#comment-308561
 ] 

Benson Margulies commented on MJAVADOC-342:
-------------------------------------------

THis is more likely to get fixed with test case(s) attached.
                
> An incomplete fix for the NPE bugs in AbstractJavadocMojo.java
> --------------------------------------------------------------
>
>                 Key: MJAVADOC-342
>                 URL: https://jira.codehaus.org/browse/MJAVADOC-342
>             Project: Maven 2.x Javadoc Plugin
>          Issue Type: Bug
>            Reporter: Guangtai Liang
>            Priority: Critical
>
> The fix revision 554202 was aimed to remove an NPE bug on the  returned value 
> of  "getJavadocDirectory()" in the method "getSourcePaths " of the file 
> "/maven/plugins/trunk/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java"
>  , but it is incomplete. 
> Since the returned value  "getJavadocDirectory()" could be null during the 
> runtime execution, its value should also be null-checked before being 
> dereferenced in other methods. 
> The buggy code locations the same fix needs to be applied at are as bellows: 
> Line 2401 of the method "copyJavadocResources";
> Line 1505 of the method "getSourcePaths". 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to