[ 
https://jira.codehaus.org/browse/MNG-5309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=304630#comment-304630
 ] 

Milos Kleint commented on MNG-5309:
-----------------------------------

one stopper problem is that equals/hashcode on Xpp3DOM work with the values of 
the entire subtree. Once we create the locations tree with Xpp3DOM as keys in 
InputLocation, we arrive at a problem once ModelInterpolator is invoked on the 
pom file. any expression in any value invalidates the entire locations subtree 
because the hashcode/equals values changes and the maps in InputLocation keep 
the old hash as reference for lookup of values.
                
> InputLocation missing for Xpp3Dom configuration elements
> --------------------------------------------------------
>
>                 Key: MNG-5309
>                 URL: https://jira.codehaus.org/browse/MNG-5309
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: Embedding, IDEs, Inheritance and Interpolation, POM
>    Affects Versions: 3.0.4
>            Reporter: Milos Kleint
>            Assignee: Milos Kleint
>         Attachments: 2012-07-06_1548.png, mng_configuration.patch
>
>
> I'm trying to create a view over a pom.xml file that displays current 
> effective pom, along with showing which line came from which pom. Works more 
> or less ok, with the provided InputLocations with one significant exception. 
> <configuration> element in <plugin>. See screenshot.
> The idea in the patch is to have the InputLocation tree mimic the tree of 
> Xpp3Dom objects. All the merges of Xpp3Dom then manipulate the tree of 
> InputLocations as well.
> The patch included is not complete, just proof of concept, needs to have 
> proper InputLocation creating in Xpp3DomMavenReaderExt file (I've replaced 
> that by some quick post processing, changing modello plugins to generate 
> something else is error prone slow to to start with). Additionally the 
> default Xpp3Dom merging from plexus-utils is replaced by maven's own version 
> of merge code. Not sure there if it's possible/practical to move that code 
> down to the dependency.
> also some additional tests are required to be written

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to