[
https://jira.codehaus.org/browse/SCM-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=301415#comment-301415
]
Svend Hansen edited comment on SCM-678 at 6/19/12 5:11 AM:
-----------------------------------------------------------
I don't think the canonical path is causing the problem, but it's just
revealing it.
I'm not completely sure I understand the code and how it _should_ be working,
but as far as I can see:
1) The files in the {{ScmFileSet}} passed into the two methods at actual
runtime seem to be absolute, so using them with the ScmFileSet's {{basedir}}
doesn't seem to make sense?
2) All the tests seem to set the {{basedir}} to '.' and then pass in a separate
{{workingDirectory}} or {{workingDir}}, which it self seems to be relative
(e.g. "baz/qux").
3) I guess this breaks _less_ in linux as
{{/home/me/project/home/me/project/pom.xml}} is still a valid file path (though
it would be pointing to a wrong place, of course).
I'm not sure if the bug is that the method doesn't handle absolute paths
(before my change), or that the paths of the files are absolute. I think that
the latter would be a bug somewhere else in the containing/calling maven
modules (maven release plugin, etc).
How to I create a patch? Do I just commit my changes through SVN?
I can write a Junit test that breaks without my change, but works with... Or
should I just add another test method to the {{PerforceEditCommandTest}} and
{{PerforceCheckInCommandTest}}?
was (Author: svendhhh):
I don't think the canonical path is causing the problem, but it's just
revealing it.
I'm not completely sure I understand the code, but as far as I can see:
1) The files in the {{ScmFileSet}} passed into the two methods at actual
runtime seem to be absolute, so using them with the ScmFileSet's {{basedir}}
doesn't seem to make sense?
2) All the tests seem to set the {{basedir}} to '.' and then pass in a separate
{{workingDirectory}} or {{workingDir}}, which it self seems to be relative
(e.g. "baz/qux").
3) I guess this breaks _less_ in linux as
{{/home/me/project/home/me/project/pom.xml}} is still a valid file path (though
it would be pointing to a wrong place, of course).
I'm not sure if the bug is that the method doesn't handle absolute paths
(before my change), or that the paths of the files are absolute. I think that
the latter would be a bug somewhere else in the containing/calling maven
modules (maven release plugin, etc).
How to I create a patch? Do I just commit my changes through SVN?
I can write a Junit test that breaks without my change, but works with... Or
should I just add another test method to the {{PerforceEditCommandTest}} and
{{PerforceCheckInCommandTest}}?
> CLONE - mvn release:prepare fails with IOException and a write error (Access
> is denied)
> ---------------------------------------------------------------------------------------
>
> Key: SCM-678
> URL: https://jira.codehaus.org/browse/SCM-678
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-perforce
> Affects Versions: 1.7
> Environment: Windows 7 both command prompt and cygwin using Perforce
> for SCM
> Reporter: Robert Scholte
> Attachments: maven-release-error.txt,
> mvn_release_output_x_client_env.txt, mvn_release_output_x.txt
>
>
> When running
> {{mvn release:prepare -Dusername=<perforce_user>
> -Dpassword=<perforce_password>}}
> I get the errors:
> * java.io.IOException: The filename, directory name, or volume label syntax
> is incorrect
> * [ERROR] CommandLineException Exit code: 1 - Usage: add/edit/delete [-c
> changelist#] [ -d -f -k -n -v ] [-t type] files...
> Missing/wrong number of arguments.
> * [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:2.3.1:prepare (default-cli) on
> project root-project: Error writing POM: D:\Server\pom.xml (Access is denied)
> -> [Help 1]
> The full output is attached.
> Sometimes I also get the error:
> * [ERROR] D:\Server\pom.xml - file(s) not in client view.
> Though I created the client in the same location I'm running from, and I'm
> not sure that error is related to the others (as the others also occur when
> that one doesn't).
> It's been suggested (on stackoverflow:
> http://stackoverflow.com/questions/10999403/maven-releaseprepare-ioexception)
> that the error has to do with my D drive being a mapped drive, though I don't
> think it is as it's not listed if I run {{subst}}. However, I think it _must_
> be at least a partition on the same hard drive, unless my PC has three
> physical drives :P (work PC), but I guess that shouldn't make any difference
> to the program?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
