[ 
https://jira.codehaus.org/browse/SCM-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=297000#comment-297000
 ] 

Chris Graham commented on SCM-154:
----------------------------------

I think this issue can be closed, as I can build the entire SCM project, and I 
do not have bzr installed.

Additionally, the other means to pass the tests, is to check for the existance 
of the tool (using ScmTestCase.isSystemCmd()), as is done in the cvs, svn and 
git tests.

There is quite a bit of variety in the implementation of all of the providers, 
not surprising given the age of the code base and the number of people who have 
worked on it over the years.

I would like to see a bit of cleanup, to bring consistency in implementation to 
the code base.

I don't agree with Emmanuel's comments. Yes they are easy to obtain and 
install, however, this goes against the general maven ethos of running maven 
and it will download and install what it needs to run. 

So I'd like to see any and all tests that call the underlying executable 
(obviously all of the non-java implementations) moved to the Tck tests.
The JUnit tests that remain should be the command line tests and any other 
tests (parsing the URL string, testing consumers etc) to remain where they are.


                
> Bazaar tests should not assume bzr is installed
> -----------------------------------------------
>
>                 Key: SCM-154
>                 URL: https://jira.codehaus.org/browse/SCM-154
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-bazaar
>    Affects Versions: 1.0-beta-3
>            Reporter: Mike Perham
>            Assignee: Torbjørn EIkli Smørgrav
>            Priority: Critical
>             Fix For: future
>
>
> Bazaar breaks my SCM build because it assumes it is installed.  I do not 
> think the user should be forced to install Bazaar just to compile the SCM 
> codebase.  See the StarTeam, Perforce and ClearCase providers for examples of 
> providers which do not assume an installation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to