[
https://jira.codehaus.org/browse/MCHECKSTYLE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=292280#comment-292280
]
SebbASF commented on MCHECKSTYLE-172:
-------------------------------------
Yes.
The original report that triggered the JIRA is here:
http://www.mailinglistarchive.com/html/[email protected]/2011-12/thrd4.html#00134
AIUI, the OP was complaining about two issues:
- 2.8 now generates an additional aggregate report
- the aggregate report has incorrect counts
2.9 fixes the incorrect count problem, but not the additional aggregate report.
Unfortunately, the JIRA settings at Codehaus are such that I could not re-open
the original JIRA so I had to clone it.
[I intended to add some further explanation, but obviously forgot, sorry.]
It does not seem right that since 2.8 every Maven project now gets an
additional aggregate report, regardless of whether the project actually has any
modules to aggregate.
> Checkstyle runs aggregate report on projects without modules
> ------------------------------------------------------------
>
> Key: MCHECKSTYLE-172
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-172
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Bug
> Affects Versions: 2.8
> Environment: {{{
> mvn --version
> Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home:
> /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> }}}
> Reporter: SebbASF
>
> Using a very simple single module project, the aggregated report is created
> by default and reports an incorrect number of violations, it just doubles the
> numbers. I checked out
> http://svn.apache.org/repos/asf/maven/plugins/tags/maven-checkstyle-plugin-2.8
> and modified the integration test project {{checkstyle-report}} a little bit:
> * I deleted the {{reportSets}} configuration from the {{pom.xml}}.
> * I modified {{src/main/java/org/MyClass.java}} to actually have errors.
> The build log looks like this:
> {code}
> [mirko@borg checkstyle-report]$ mvn clean site
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Building check-pass 1.0-SNAPSHOT
> [INFO]
> ------------------------------------------------------------------------
> [INFO]
> [INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ check-pass ---
> [INFO] Deleting
> /Users/mirko/Documents/workspace/maven-checkstyle-plugin/target/it/checkstyle-report/target
> [INFO]
> [INFO] --- maven-site-plugin:3.0:site (default-site) @ check-pass ---
> [INFO] configuring report plugin
> org.apache.maven.plugins:maven-checkstyle-plugin:2.8
> [INFO] Relativizing decoration links with respect to project URL:
> http://maven.apache.org/
> [INFO] Rendering site with org.apache.maven.skins:maven-default-skin:jar:1.0
> skin.
> [INFO] Generating "Checkstyle" report --- maven-checkstyle-plugin:2.8
> [INFO]
> [INFO] There are 2 checkstyle errors.
> [WARNING] Unable to locate Source XRef to link to - DISABLED
> [INFO] Generating "Checkstyle" report --- maven-checkstyle-plugin:2.8
> [INFO]
> [INFO] There are 4 checkstyle errors.
> [WARNING] Unable to locate Source XRef to link to - DISABLED
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 4.847s
> [INFO] Finished at: Tue Nov 29 21:13:40 CET 2011
> [INFO] Final Memory: 12M/81M
> [INFO]
> ------------------------------------------------------------------------
> {code}
> {{target/checkstyle-result.xml}} looks like this and reports the same errors
> twice:
> {code}
> <?xml version="1.0" encoding="UTF-8"?>
> <checkstyle version="5.4">
> <file
> name="/Users/mirko/Documents/workspace/maven-checkstyle-plugin/target/it/checkstyle-report/src/main/java/org/MyClass.java">
> <error line="7" column="5" severity="error" message="Missing a Javadoc
> comment."
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck"/>
> <error line="7" column="22" severity="error" message="Parameter args should
> be final."
> source="com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck"/>
> </file>
> <file
> name="/Users/mirko/Documents/workspace/maven-checkstyle-plugin/target/it/checkstyle-report/src/main/java/org/MyClass.java">
> <error line="7" column="5" severity="error" message="Missing a Javadoc
> comment."
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck"/>
> <error line="7" column="22" severity="error" message="Parameter args should
> be final."
> source="com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck"/>
> </file>
> </checkstyle>
> {code}
> Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated and
> {{checkstyle-aggregate}} reports the same errors twice. I attach the patched
> project which includes a check in {{verify.groovy}} to assert that only one
> {{file}} entry is present in the created {{target/checkstyle-result.xml}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
