[ 
https://jira.codehaus.org/browse/MRELEASE-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=291036#comment-291036
 ] 

Stephen Connolly commented on MRELEASE-459:
-------------------------------------------

Needs some integration tests that fail before the patch is applied and pass 
after the patch is applied to:

1. prove there is an issue

2. prove the issue is fixed

3. prevent the issue from arising again.

I know this looks like a simple fix, but we really need integration tests to 
apply patches or quality will just decrease
                
> releaseProfiles has no effect without passing profiles in the command line 
> ---------------------------------------------------------------------------
>
>                 Key: MRELEASE-459
>                 URL: https://jira.codehaus.org/browse/MRELEASE-459
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>          Components: perform
>    Affects Versions: 2.0-beta-8, 2.0-beta-9
>            Reporter: Andreas Christoforides
>         Attachments: MRELEASE-459.1.patch, patch.txt
>
>
> The releaseProfiles parameter on the perform goal is not taken into 
> consideration when no other profiles are passed in the command line. In other 
> words, the current code only uses the value of the parameter if you have 
> additional profiles passed in. 
> Example:
> mvn release:perform -P someProfile (uses releaseProfiles value)
> mvn release:perform (does NOT use releaseProfiles value)
> The plugin should use the parameter even if no other profiles are passed. It 
> should actually encourage release profiles configured in your POM as opposed 
> to arbitrary profiles passed in the command line.
> I have included a patch that uses the releaseProfiles parameter regardless of 
> any profiles passed in the command line.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to