set the useDefaultManifestFile = true by default for a more convention over 
configuration approach to maven and manifests; letting folks just add a 
MANIFEST.MF and for it to be used by default without any user 
interaction/config change
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: MJAR-146
                 URL: https://jira.codehaus.org/browse/MJAR-146
             Project: Maven 2.x JAR Plugin
          Issue Type: Improvement
    Affects Versions: 2.3.2
            Reporter: james strachan


It feels a bit nicer that maven will just automatically use a 
META-INF/MANIFEST.MF file if its available; rather than folks having to google 
for the maven-jar-plugin configuration; then adding a mvn <plugins> section 
overriding the configuration of the jar plugin just to set this flag - just so 
that maven-jar-plugin can then decide to look for a MANIFEST.MF.

Afterall the plugin silently ignores this setting anyway if this setting is 
true and there's no file. So it feels nicer to users to use the MANIFEST.MF if 
they supply one out of the box. If they supply a MANIFEST.MF file and they 
really don't want it to be used; then they can set the flag to false (as its a 
slightly strange scenario anyway - why would you put a source file there if you 
didn't want it to be used? You'd just move it somewhere else or rename it - 
again without having to muck about with plugin configurations).

I guess someone might want to add a requiresDefaultManifestFile=true flag 
(which defaults to false) so that the jar plugin will fail the build if a 
MANIFEST.MF file is not found (as the default manifest my be designed to add 
some dubtle definitions or something and you want to protect the build from 
folks moving the MANIFEST.MF around or something). 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to