[ 
https://jira.codehaus.org/browse/MSITE-484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Dalquist updated MSITE-484:
--------------------------------

    Attachment: MSITE-484.patch

Updated patch, replaces mergePolicy. prefix with merge: xml namespace. In my 
testing you can specify whatever you want for the namespace URI since I don't 
actually have an XSD to go with it, I used 
xmlns:merge="http://maven.apache.org/plugin-merge"; in my test pom.

This patch should be complete, all integration tests pass and the copyright 
headers are correct. I do have an Apache ICLA on file and am an active 
committer in the portals project: http://people.apache.org/committer-index.html

I would love this to become a core feature of Maven itself for merging plugin 
configurations. I'm not sure where to go with getting that requested as a 
feature. I'm hoping that this this seems to affect the site plugin more than 
others it would be faster to get the fix in here so it could be used as soon as 
possible.

> Support adding and overriding report plugins in new maven-site-plugin 3.x 
> reportPlugins configuration format
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: MSITE-484
>                 URL: https://jira.codehaus.org/browse/MSITE-484
>             Project: Maven 2.x and 3.x Site Plugin
>          Issue Type: Bug
>          Components: inheritance, Maven 3
>    Affects Versions: 3.0-beta-1, 3.0-beta-2, 3.0-beta-3
>         Environment: 3.0-beta-1-SNAPSHOT
>            Reporter: Michael Pilquist
>            Assignee: Olivier Lamy
>             Fix For: 3.1
>
>         Attachments: MSITE-484.patch, MSITE-484.patch, 
> site-cfg-inheritance.zip
>
>
> When using the new configuration format for reportPlugins, it appears that 
> there's no way to:
> - Add a report plugin to a submodule
> - Override the configuration of a report plugin in a submodule
> Using the old <reporting> section, both of these use cases were supported.  
> For large, multi-module builds, it is problematic having to respecify all 
> reporting plugins in any submodule pom that needs to either add an additional 
> reporting plugin or change the configuration of a reporting plugin.
> Attached is a sample project that has a parent POM configured with 
> project-info-reports and javadoc plugin and a submodule configured with jxr 
> plugin and javadoc plugin.  The relevant output is here:
> {code}
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Building parent 1.0-SNAPSHOT
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] 
> [INFO] --- maven-clean-plugin:2.3:clean (default-clean) @ parent ---
> [INFO] Deleting file set: /Users/mpilquist/Downloads/site-parent-issue/target 
> (included: [**], excluded: [])
> [INFO] 
> [INFO] --- maven-site-plugin:3.0-beta-1-SNAPSHOT:site (default-site) @ parent 
> ---
> [INFO] configuring reportPlugin 
> org.apache.maven.plugins:maven-project-info-reports-plugin:2.2
> [INFO] configuring reportPlugin 
> org.apache.maven.plugins:maven-javadoc-plugin:2.6.1
> ...
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Building parent-usage-test 1.0-SNAPSHOT
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] 
> [INFO] --- maven-clean-plugin:2.3:clean (default-clean) @ parent-usage-test 
> ---
> [INFO] 
> [INFO] --- maven-site-plugin:3.0-beta-1-SNAPSHOT:site (default-site) @ 
> parent-usage-test ---
> [INFO] configuring reportPlugin org.apache.maven.plugins:maven-jxr-plugin:2.1
> [INFO] configuring reportPlugin 
> org.apache.maven.plugins:maven-javadoc-plugin:2.6.1
> {code}
> Looking at the maven-site-plugin code, it appears the the reportPlugins 
> parameter is just a regular array parameter.  AFAIK, there's no way to merge 
> list configuration items.  Other plugins have worked around this by defining 
> additional mojo parameters (e.g., maven-eclipse-plugin and buildCommands / 
> additionalBuildCommands -- 
> http://maven.apache.org/plugins/maven-eclipse-plugin/eclipse-mojo.html).  
> This isn't the most flexible option though as it only solves 1 level 
> inheritance.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to