[ 
https://jira.codehaus.org/browse/MASSEMBLY-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=274153#comment-274153
 ] 

Julien HENRY commented on MASSEMBLY-561:
----------------------------------------

Hi John,

The difficulty here is that the encoding of the test file should be ISO-8859-1 
where all other files are UTF-8. I'm not sure applying svn patch is safe in 
this case. Could you please chech that encoding of 
src/it/projects/filtering-feature/filter-encoding-iso88591/src/main/config/iso88591.config
 is ISO-8859-1 and that the french character was not corrupted by making 
patch/uploading on JIRA//applying patch.

Thanks

> Encoding is broken when filtering is enabled
> --------------------------------------------
>
>                 Key: MASSEMBLY-561
>                 URL: https://jira.codehaus.org/browse/MASSEMBLY-561
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2.1
>            Reporter: Julien HENRY
>            Priority: Critical
>         Attachments: MASSEMBLY-561.patch
>
>
> My resources are encoded in ISO-8859-1. I have specified encoding in the pom: 
> {code}<project.build.sourceEncoding>ISO-8859-1</project.build.sourceEncoding>{code}
> I have written a custom assembly file and I am using resource filtering.
> {code}...
> <fileSet>
>       <directory>${project.basedir}/src/main/resources/</directory>
>       <outputDirectory>/</outputDirectory>
>       <filtered>true</filtered>
> </fileSet>
> ...{code}
> As a result all the french characters are broken in the resulting zip 
> assembly. My platform is Linux so the default platform encoding is UTF-8.
> I have checked plugin code and I think I found the issue. This is in 
> FileFormatter.java, method doFileFilter():
> {code}
>             configSource.getMavenFileFilter().copyFile( source, target, true, 
> configSource.getProject(),
>                     configSource.getFilters(), isPropertiesFile, null, 
> configSource.getMavenSession() );
> {code}
> You can see that enconding is set to null, so I think it means using default 
> platform encoding... Would it be possible to use value of 
> project.build.sourceEncoding instead?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to