[
https://jira.codehaus.org/browse/MSHADE-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=272056#comment-272056
]
Benson Margulies edited comment on MSHADE-88 at 7/2/11 6:18 AM:
----------------------------------------------------------------
r1141937 | bimargulies | 2011-07-01 09:50:47 -0400 (Fri, 01 Jul 2011) | 5 lines
[MSHADE-88]: Pom type dependencies are incorrectly included in dependency
reduced pom
Submitted by: antelder
also integration test for antelder's change. Also update to current parent.
------------------------------------------------------------------------
was (Author: bmargulies):
r1141937 | bimargulies | 2011-07-01 09:50:47 -0400 (Fri, 01 Jul 2011) | 3
lines
[MSHADE-88]: antelder: fix an interaction between 'createDependencyReducedPom'
and
'promoteTransitiveDependencies'. also integration test. Also update to current
parent.
------------------------------------------------------------------------
/Users/benson/asf/mvn/plugins/maven-shade-plugin
> Pom type dependencies are incorrectly included in dependency reduced pom
> ------------------------------------------------------------------------
>
> Key: MSHADE-88
> URL: https://jira.codehaus.org/browse/MSHADE-88
> Project: Maven 2.x Shade Plugin
> Issue Type: Bug
> Affects Versions: 1.4
> Reporter: ant elder
> Assignee: Benson Margulies
> Fix For: 1.5
>
> Attachments: drpFix.txt, MSHADE-88-2.patch
>
>
> When shading with promoteTransitiveDependencies and
> createDependencyReducedPom set to true and using dependencies with a type of
> pom then the dependency reduced pom still includes the pom type dependencies,
> this is incorrect because the dependencies of the pom type dependency have
> already been included in the shaded artifact.
> The attached patch (based on trunk) fixes this by not including pom type
> dependencies to the dependency reduced pom. There are no existing tests for
> dependency reduced pom's or with pom type dependencies but this patch code
> does match what is already done for pom type dependencies in the ShadeMojo
> execute method at line 409.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
