[
http://jira.codehaus.org/browse/MNG-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=253297#action_253297
]
Kristian Rosenvold commented on MNG-3321:
-----------------------------------------
Kalyan; thanks for the patch, which I think looks very good, the unit tests
were good. I have a few comments:
1. License headers must be added to all the new files.
2. Any features added to core also have corresponding integration tests, which
are in a separate project
(https://svn.apache.org/repos/asf/maven/core-integration-testing/trunk). In
this case I believe the tests should cover skipping plugin and execution and
demonstrate end-to-end effect of the feature. We do not commit new features
such as this without such tests.
3. Documentation. This needs to be added to the documentation, somewhere ;)
4. Code style. This is only a minor issue but if you use the ide-templates at
http://maven.apache.org/developers/committer-environment.html while making
patches, your patch will
follow maven code style. In general this makes the patch easier to apply and
reduce the risk of patch rot.
> Skip plugin and/or execution
> ----------------------------
>
> Key: MNG-3321
> URL: http://jira.codehaus.org/browse/MNG-3321
> Project: Maven 2 & 3
> Issue Type: New Feature
> Components: Command Line
> Affects Versions: 2.0.8
> Reporter: Paul Gier
> Fix For: Issues to be reviewed for 3.x
>
> Attachments: MNG-3321-maven-core.patch
>
>
> Add ability to skip the execution of certain plugins. From the command line
> this could look something like:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin
> install {code}
> Also useful would be the ability to skip individual executions of a plugin.
> For example, if the surefire plugin had two executions defined as "ex1" and
> "ex2", you could do something like this:
> {code} mvn -Dskip.plugin:org.apache.maven.plugins:maven-surefire-plugin:ex1
> install {code}
> This would skip ex1 but still run ex2.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
