[
http://jira.codehaus.org/browse/MNG-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Bentmann updated MNG-4862:
-----------------------------------
Issue Type: Improvement (was: Bug)
Yes, while ultimately a stronger typed signature is desired, this shouldn't be
based on {{Xpp3Dom}} but something from the Maven domain. {{Xpp3Dom}} is an
implementation detail, that ideally gets properly abstracted by means of an
interface.
> ConfigurationContainer.configuration should be of type Xpp3Dom, not Object
> --------------------------------------------------------------------------
>
> Key: MNG-4862
> URL: http://jira.codehaus.org/browse/MNG-4862
> Project: Maven 2 & 3
> Issue Type: Improvement
> Components: Embedding
> Affects Versions: 3.0
> Reporter: Jesse Glick
> Priority: Minor
>
> All references to ConfigurationContainer.configuration, including the
> get/setConfiguration methods, treat it as a
> org.codehaus.plexus.util.xml.Xpp3Dom instance. Yet the signature is Object,
> and the Javadoc does not even mention the actual type. This is confusing and
> error-prone.
> Suggest changing the signature throughout to Xpp3Dom. If this cannot be done
> for reasons of binary compatibility, I would suggest: change the signature of
> the field; introduce a new setConfiguration(Xpp3Dom); @Deprecate
> setConfiguration(Object) and make it just call setConfiguration(Xpp3Dom)
> after casting; and update the Javadoc of getConfiguration to specify that it
> will always return an Xpp3Dom instance (or maybe null). (While the JVM is
> happy to have two no-arg methods with the same name but different return
> types, javac will not allow it; possible only by postprocessing bytecode.)
> Could also introduce new method names, e.g. get/setConfigurationDom.
> It seems that the bug may ultimately be in modello-plugin-java for handling
> <type>DOM</type> poorly. (JavaModelloGenerator, introduced by brett,
> commented on by demers.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
