[ http://jira.codehaus.org/browse/SUREFIRE-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=221900#action_221900 ]
A edited comment on SUREFIRE-576 at 5/20/10 4:49 AM: ----------------------------------------------------- Hello, I've tested the changes today. It seems like the filter is actually including what user chooses in the exclude elements. {code} private Set filterArtifacts( Set artifacts, ArtifactFilter filter ) { Set filteredArtifacts = new LinkedHashSet(); for ( Iterator iter = artifacts.iterator(); iter.hasNext(); ) { Artifact artifact = (Artifact) iter.next(); if ( filter.include( artifact ) ) { filteredArtifacts.add( artifact ); } } return filteredArtifacts; } {code} Perhaps you intended it as "if ( ! filter.include( artifact ) )"? Another glitch I'm seeing is that description of the scope excludes element is misleading. compile+runtime doesn't seem to be recognized as a valid option for filtering but "runtime" alone is what works for me. Also I can't make "runtime+system" working neither "system". I've no why. Thanks! was (Author: avalon): Hello, I've tested the changes today. It seems like the filter is actually including what user chooses in the exclude elements. [code] private Set filterArtifacts( Set artifacts, ArtifactFilter filter ) { Set filteredArtifacts = new LinkedHashSet(); for ( Iterator iter = artifacts.iterator(); iter.hasNext(); ) { Artifact artifact = (Artifact) iter.next(); if ( filter.include( artifact ) ) { filteredArtifacts.add( artifact ); } } return filteredArtifacts; } [/code] Perhaps you intended it as "if ( ! filter.include( artifact ) )"? Another glitch I'm seeing is that description of the scope excludes element is misleading. compile+runtime doesn't seem to be recognized as a valid option for filtering but "runtime" alone is what works for me. Also I can't make "runtime+system" working neither "system". I've no why. Thanks! > Have the abiltiy to remove a dependency from the test classpath (at least > optional ones > --------------------------------------------------------------------------------------- > > Key: SUREFIRE-576 > URL: http://jira.codehaus.org/browse/SUREFIRE-576 > Project: Maven Surefire > Issue Type: New Feature > Components: classloading, Maven Surefire Plugin > Reporter: Hardy Ferentschik > Assignee: Paul Gier > Fix For: 2.6 > > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira