SettingsUtils.copySettings does not perform a deep copy
-------------------------------------------------------

                 Key: MNG-4657
                 URL: http://jira.codehaus.org/browse/MNG-4657
             Project: Maven 2 & 3
          Issue Type: Bug
          Components: Settings
    Affects Versions: 2.2.1
            Reporter: Edouard Hue
            Priority: Minor


The org.apache.maven.settings.SettingsUtils.copySettings method only creates a 
new Settings instance and then copies all its attributes by reference, 
including lists such as profiles or proxies. Hence, modifying the copy can 
produce unexpected side effects on the original object.

Expected behavior is that a deep copy is returned, or documentation should 
mention this behaviour. Maybe make it implement Clonable ?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to