[ 
http://jira.codehaus.org/browse/MECLIPSE-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=219354#action_219354
 ] 

Ramiro Pereira de Magalhães edited comment on MECLIPSE-636 at 4/29/10 3:24 AM:
-------------------------------------------------------------------------------

Added a patch that solves this issue using patches and suggestions from 
MECLIPSE-156. Now, eclipse:eclipse uses the <encoding> text from the 
maven-compiler-plugin to set source code's and resources' encoding. It does not 
set the global encoding setting of an Eclipse project, so only the source and 
resource folders will have the encoding set. Also, fixed the eclipse:clean 
mojo, allowing it to properly exclude the 
.settings/org.eclipse.core.resources.prefs file which contains such preferences.

      was (Author: ramiromagalhaes):
    Added a patch that solves this issue using patches from MECLIPSE-156 and 
suggestions that came from this thread. Now, eclipse:eclipse uses the 
<encoding> text from the maven-compiler-plugin to set source code's and 
resources' encoding. It does not set the global encoding setting of an Eclipse 
project, so only the source and resource folders will have the encoding set. 
Also, fixed the eclipse:clean mojo, allowing it to properly exclude the 
.settings/org.eclipse.core.resources.prefs file which contains such preferences.
  
> MECLIPSE-156 wasn't resolved
> ----------------------------
>
>                 Key: MECLIPSE-636
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-636
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: Core : Workspace settings
>    Affects Versions: 2.7
>            Reporter: Ramiro Pereira de Magalhães
>         Attachments: patch-MECLIPSE-636.patch
>
>
> Task MECLIPSE-156 wasn't correctly implemented and the proposed feature 
> (namely, that the plugin should support setting file encoding) does not work. 
> I think that only one of the proposed patches there were implemented (on 
> IdeUtils.java) while the other (on EclipseUtils.java) one wasn't.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to