[
http://jira.codehaus.org/browse/MNG-4597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=214280#action_214280
]
Paul Benedict commented on MNG-4597:
------------------------------------
This effort may be probably better suited to the 3.0 code base?
> FindBugs analysis effects
> -------------------------
>
> Key: MNG-4597
> URL: http://jira.codehaus.org/browse/MNG-4597
> Project: Maven 2 & 3
> Issue Type: Bug
> Affects Versions: 2.2.1
> Environment: n/a
> Reporter: M Pazurkiewicz
> Priority: Minor
> Fix For: 2.2.2
>
>
> I've run a FindBugs analysis for the 2.2.1 sources.
> I found a number of minor issues:
> * lots of unread fields
> * misleading class naming
> (org.apache.maven.artifact.repository.metadata.RepositoryMetadataInstallationException
>
> and
> org.apache.maven.artifact.repository.metadata.RepositoryMetadataDeploymentException
> do not inherit from Exception class)
> * using Number constructors instead of static valueOf (the latter is
> significantly more efficient)
> And as far as more serious issues:
> In src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
> I found a curious self-assignment:
> public void setSession( MavenSession session )
> {
> session = session;
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
