[
http://jira.codehaus.org/browse/MSHARED-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=213478#action_213478
]
Guillaume Nodet commented on MSHARED-98:
----------------------------------------
What I've fixed as part of FELIX-2173 is slightly different.
The problem was that the osgi conversion used to convert '-' to '_' in the
qualifier without any real need for that.
The patch I used is available at
http://svn.apache.org/viewvc/felix/trunk/bundleplugin/src/main/java/org/apache/maven/shared/osgi/DefaultMaven2OsgiConverter.java?p2=/felix/trunk/bundleplugin/src/main/java/org/apache/maven/shared/osgi/DefaultMaven2OsgiConverter.java&p1=/felix/trunk/bundleplugin/src/main/java/org/apache/maven/shared/osgi/DefaultMaven2OsgiConverter.java&r1=919426&r2=919425&view=diff&pathrev=919426
I used the BND mechanism modified to honor the padding as it was the case
previously.
Removing the padding should be as simple as deleting three lines in the above
patch.
> Maven2OsgiConverter unnecessarily pads version numbers
> ------------------------------------------------------
>
> Key: MSHARED-98
> URL: http://jira.codehaus.org/browse/MSHARED-98
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-osgi
> Reporter: Matthew Beermann
> Attachments: MSHARED-98-maven-osgi.patch, MSHARED-98-maven-osgi.patch
>
>
> In DefaultMavenOsgiConverter#getVersion(), there's logic to the effect of:
> /* convert
> * 1.string -> 1.0.0.string
> * 1.2.string -> 1.2.0.string
> * 1 -> 1.0.0
> * 1.1 -> 1.1.0
> */
> ...which is unnecessary; the version number only needs to be padded out to
> three places when there's a qualifier present.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
