[
http://jira.codehaus.org/browse/MNG-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=186084#action_186084
]
John Casey commented on MNG-4275:
---------------------------------
I'll take a crack at the test case today.
> [regression] Direct relocations no longer log at WARNING level : MNG-3380
> conflicts with MNG-1689
> -------------------------------------------------------------------------------------------------
>
> Key: MNG-4275
> URL: http://jira.codehaus.org/browse/MNG-4275
> Project: Maven 2
> Issue Type: Bug
> Components: Dependencies
> Affects Versions: 2.2.0
> Environment: Apache Maven 2.2.1-RC2-SNAPSHOT (r799976; 2009-08-02
> 19:18:34+1000)
> Java version: 1.6.0_14
> Java home: /usr/lib/jvm/java-6-sun-1.6.0.14/jre
> Default locale: en_AU, platform encoding: UTF-8
> OS name: "linux" version: "2.6.28-14-generic" arch: "amd64" Family: "unix"
> Reporter: Brett Randall
> Assignee: John Casey
> Priority: Minor
> Fix For: 2.2.1
>
> Attachments: MNG-4275.maven-trunks.patch
>
>
> Changes for MNG-3380 [1] to Process relocations before child-nodes are
> discovered during artifact collection, conflict with MNG-1689 [2] " Only
> print relocation warnings in standard output for the current pom". This
> results in a regression where (direct) relocations are no longer logged at
> WARNING level and are only logged at DEBUG. Direct relocations should be
> logged at WARNING level.
> @675087 [3] MNG-3380 was applied to DefaultArtifactCollector - the result is
> that the call to MavenMetadataSource#retrieveRelocatedArtifact() (then
> retrieveRelocatedProject()) occur before the call to
> artifact.setDependencyTrail( node.getDependencyTrail() ); in
> DefaultArtifactCollector. This results in a null list in
> MavenMetadataSource, which then fails the if-test to log at WARNING level
> introduced in MNG-1689.
> With a quick inspection I couldn't see the harm in bringing forward the call
> to:
> artifact.setDependencyTrail( node.getDependencyTrail() )
> , it is already called once when about to throw an exception, and this call
> can be replaced. Proposed patch makes the setDependencyTrail call earlier,
> prior to relocation detection.
> See also Nabble post [4].
> [1] http://jira.codehaus.org/browse/MNG-3380
> [2] http://jira.codehaus.org/browse/MNG-1689
> [3] http://svn.apache.org/viewvc?view=rev&revision=675087
> [4]
> http://www.nabble.com/2.0.9-%3E2.1.0-change-regression-in-relocation-WARNING--td24368186.html
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
