[ 
http://jira.codehaus.org/browse/SCM-474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Solntsev updated SCM-474:
--------------------------------

    Attachment: MNG-474-maven-core.patch

The patch has been attached.

Short changes description:
1. Replaced SimpleDateFormat by ThreadSafeDateFormat
2. Fixed 1 bug in ChangeSet (line 337) 
3. Extracted code from ChangeSet#containsFilename to a separate class 
FilenameUtils.
4. Created bulk of unit tests

> Make class ChangeSet thread-safe
> --------------------------------
>
>                 Key: SCM-474
>                 URL: http://jira.codehaus.org/browse/SCM-474
>             Project: Maven SCM
>          Issue Type: Improvement
>          Components: maven-scm-api
>    Affects Versions: 1.3
>            Reporter: Andrei Solntsev
>            Priority: Minor
>         Attachments: MNG-474-maven-core.patch
>
>
> Class org.apache.maven.scm.ChangeSet declares a static member of type 
> SimpleDateFormat which is not thread-safe.
> If 2 concurrent treads try to use it, it will lead to error.
> Proposed solution is to use class ThreadSafeDateFormat described here: 
> http://asolntsev.blogspot.com/2009/05/threadsafedateformat.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to