[ 
http://jira.codehaus.org/browse/MEAR-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=166620#action_166620
 ] 

Daniel Pfeifer commented on MEAR-102:
-------------------------------------

To be utterly honest, I don't think anybody is ever going to use the loader 
repo class or config parser class. I mean, have you ever had to change it? 
After years with JBoss, to this day, I never altered the loader repo class.

We could leave it the way it is, I don't think it's a big deal. It's not great, 
but it works.

> Support for JBoss 5 as well as some missing elements
> ----------------------------------------------------
>
>                 Key: MEAR-102
>                 URL: http://jira.codehaus.org/browse/MEAR-102
>             Project: Maven 2.x Ear Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.3.2
>            Reporter: Daniel Pfeifer
>            Assignee: Stephane Nicoll
>             Fix For: 2.3.2
>
>         Attachments: maven-ear-plugin-jboss-additions.patch
>
>
> I had a little e-mail conversation with Jason van Zyl about some improvements 
> that I did in the Ear Plugin, he suggested I would post them here.
> Following is added:
> * Support for JBoss 5
> * Config for loader-repository-config (3.2, 4.0, 4.2, 5.0)
> * Config for library-directory (4.2 and 5.0)
> * Config for configParserClass (3.2, 4.0, 4.2, 5.0)
> * Config for loaderRepositoryClass (3.2, 4.0, 4.2, 5.0)
> * A couple of integration test projects for the new features
> To be honest, I don't feel 100% comfortable with the way one configures the 
> loader-repository part in the POM-file (maybe things should be nested to 
> resemble the jboss-app.xml a little more), however, I didn't want to alter 
> the plugin too much as to not make it.
> Anyway, have a look at the proposed changes and tell me whether you think 
> they are worth being committed to your code base.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to