[ 
http://jira.codehaus.org/browse/MECLIPSE-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=155289#action_155289
 ] 

Michael Johns commented on MECLIPSE-423:
----------------------------------------

Barrie, I pulled down the source and had a look at the changes.  Strictly 
regarding the originally filed issue, you made the exact same change I did in 
my locally patched version, so I feel confident that you've fixed the problem.

As for the bigger change of refactoring code up to a parent class... I think 
that's a good change, if a bit outside the scope of this issue.  I'll leave it 
to others to judge whether or not it's a proper change.  I'm really only 
qualified to judge the fix for the issue as I filed it.

> NullPointerException when existing Manifest.MF file has no Class-Path element
> -----------------------------------------------------------------------------
>
>                 Key: MECLIPSE-423
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-423
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: Core : Dependencies resolution and build path 
> (.classpath)
>    Affects Versions: 2.5
>            Reporter: Michael Johns
>            Assignee: Barrie Treloar
>            Priority: Minor
>             Fix For: 2.6
>
>         Attachments: pom.xml
>
>
> A NullPointerException arises when running the rad goal against a project 
> containing a manifest that has no Class-Path element.  The exception is 
> caught and the only error on the screen is "No 
> <project-path>\META-INF\MANIFEST.MF file found".  The problem is in the 
> RadManifestWriter.orderClasspath() method.  It needs to check newValue for 
> null before trying to split it up.
> Here's the manifest I had that caused the problem:
> {code}
> Manifest-Version: 1.0
> Build-Jdk: 1.4.2
> Built-By: Michael Johns
> Created-By: Apache Maven
> {code}
> Notice that it has no Class-Path element.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to