[ 
http://jira.codehaus.org/browse/DOXIA-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=147608#action_147608
 ] 

Herve Boutemy commented on DOXIA-185:
-------------------------------------

Adding the meta tag for pure XML, with an XML prolog {code:xml}<?xml 
version="1.0" ?>{code} isn't really useful: the prolog defines encoding, either 
implictely (UTF-8 by default) or explicitely

Adding the meta-tag is needed when there is no XML prolog: in this case, 
without the meta-tag, you can't know which encoding was used when writing the 
content. (XHTML without XML prolog but with meta-tag isn't really XML since it 
does not conform XML encoding convention, but that's another story).

Then you should either add the XML prolog or the meta-tag, but both isn't 
really useful.


>From an API point of view, this requires the Sink API to know what encoding 
>was used to create the Writer.


About the proposed patch: Sink API is about output.
Having an inputEncoding attribute doesn't make sense: Parser API could 
eventually have this attribute set along the Reader using the input encoding.

To pass encoding to the Sink when rendering output, RenderingContext should be 
used, either by adding an outputEncoding attribute or using the attributes Map

> Add encoding support
> --------------------
>
>                 Key: DOXIA-185
>                 URL: http://jira.codehaus.org/browse/DOXIA-185
>             Project: Maven Doxia
>          Issue Type: Improvement
>          Components: Sink API
>    Affects Versions: 1.0-alpha-10
>            Reporter: Vincent Siveton
>         Attachments: DOXIA-185.diff
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to