[ 
http://jira.codehaus.org/browse/MASSEMBLY-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=144766#action_144766
 ] 

gotama commented on MASSEMBLY-327:
----------------------------------


In analyzing the Maven Assembly Plugin code base, from what I can see, the 
<filtered> tag (child of <unpackoptions>) is not supported.

Please look at AddDependencySetsTask:170:

                UnpackOptions opts = dependencySet.getUnpackOptions();
                if ( dependencySet.isUnpack() && ( opts != null ) )
                {
                    task.setIncludes( opts.getIncludes() );
                    task.setExcludes( opts.getExcludes() );
                }

It does not appear that Maven Assembly Plugin actually supports the <filtered> 
tag given this piece of code which ignores the option.

Further, the UnpackOptions.java isFiltered() method is not referenced in the 
Maven Assembly Plugin code base.

The documentation shows that <DependencySet> supports the <UnpackOptions>, 
which contains the <filtered> option. 

If <DependencySet> supports <UnpackOptions>, it should support all three 
options; includes, excludes AND filtered - not just two of them.

This is partially implemented support for UnpackOptions. When could we see this 
completed? Would be appreciated. Thanks.



> Using filtered within dependencySet unpackOptions
> -------------------------------------------------
>
>                 Key: MASSEMBLY-327
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-327
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2-beta-2
>            Reporter: Andy Yeung
>
> The files within the unpacked jar did not apply the filters defined.
> pom configuration includes
>                               <configuration>
>                                       <filters>
>                                               
> <filter>src/assemble/filter.properties</filter>
>                                       </filters>
>                               </configuration>
> which contains 
>    storage.id=abcde
> assembly.xml defines dependency set
>               <dependencySet>
>                       <outputDirectory>/snp-agent1</outputDirectory>
>                       <unpack>true</unpack>
>                       <unpackOptions>
>                               <filtered>true</filtered>
>                       </unpackOptions>
>                       <scope>runtime</scope>
>                       <includes>
>                               <include>
>                                       XXX.agent:agent-ear-config
>                               </include>
>                       </includes>
>               </dependencySet>
> However, the files within are not filtered.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to