[
http://jira.codehaus.org/browse/MASSEMBLY-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138744#action_138744
]
detyo edited comment on MASSEMBLY-298 at 6/16/08 8:03 AM:
---------------------------------------------------------------------
No, this is different.
The "unpackOptions" works when nested within a "dependencySet", but does not
work if it is just in the "binaries" tag.
Edit: I did not see the patch at first, it seems to fix the problem, do you
think you can apply it for the beta-3 release?
was (Author: detyo):
No, this is different.
The "unpackOptions" works when nested within a "dependencySet", but does not
work if it is just in the "binaries" tag.
I looked through the code and did not see any actual handling of UnpackOptions
at this level.
Maybe simply adding:
UnpackOptions opts = binaries.getUnpackOptions();
if ( binaries.isUnpack() && ( opts != null ) )
{
task.setIncludes( opts.getIncludes() );
task.setExcludes( opts.getExcludes() );
}
to the ModuleSetAssemblyPhase.addModuleArtifact(..) (compare with
AddDependencySetsTask.addDependencySet(..))
would do the trick?
> Includes/Excludes within <unpackOptions> are ignored
> ----------------------------------------------------
>
> Key: MASSEMBLY-298
> URL: http://jira.codehaus.org/browse/MASSEMBLY-298
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-2
> Environment: Maven 2.0.8, Intel Mac 10.5, JDK 5.0
> Reporter: Nathaniel Harward
> Attachments: module-set-assembly-phase.patch
>
>
> I have the following snippet in my assembly descriptor which does not work:
> --snip--
> <moduleSet>
> <includes>
> <include>my:module</include>
> </includes>
> <binaries>
> <unpack>true</unpack>
> <unpackOptions>
> <excludes>
> <exclude>META-INF/**</exclude>
>
> <exclude>**/.do_not_remove</exclude>
> </excludes>
> </unpackOptions>
> <outputFileNameMapping/>
> <outputDirectory>/</outputDirectory>
> <fileMode>644</fileMode>
> <directoryMode>755</directoryMode>
> </binaries>
> </moduleSet>
> --snip--
> Debug output shows:
> --snip--
> [DEBUG] includes:
> **/*
> [DEBUG] excludes:
> none
> --snip--
> I believe the problem is at line 271/272 of ModuleSetAssemblyPhase (in the
> 2.2-beta-2 revision, anyway) -- it calls "task.setUnpack( binaries.isUnpack()
> );" but does not set the unpack options (if present), hence they are ignored
> :(
> Patch is attached, and works just fine in my case above.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
