[ 
http://jira.codehaus.org/browse/MSITE-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138292#action_138292
 ] 

Brian Hanafee commented on MSITE-312:
-------------------------------------

The issue isn't with the parent having access to properties defined in the 
child's POM. I don't expect that rendering the site for the parent POM would 
magically find the value defined in some child project. My expectation is that 
when the child site is rendered, the value of childprop is available and should 
be substituted into all the menus, including the inherited menus. In the 
attached example, the child site.xml has reference to ${childprop} in an 
inherited menu and reference to ${childprop} in a locally defined menu. When 
the child site is rendered, only the second reference is substituted.

I obviously cut down the original site.xml files a lot to construct the 
example. In the original case, I was trying to create a parent menu to be 
shared by multiple projects. I want each subproject to have some common menu 
items. A part of the URL in some of those menus requires a unique identifier 
that is specific to the project. Each child project is expected to provide a 
value for that property. When the child site is rendered, I want the property 
value defined by the child to be substituted into the inherited menus.

MSITE-135 is saying that ${project.*} should be interpolated in the context of 
the child project rather than the parent project. MSITE-312 is saying that the 
same should be true for all properties - they should be evaluated in the 
context of the child. If the property is defined in the child, that value 
should be used in the menus the child inherits. Inheriting properties from the 
parent is not sufficient for inheritance. There also needs to be the ability to 
override the properties defined in the parent with new property values defined 
in the child. In the example, the parent POM doesn't  have a property named 
childprop, but I contend that even if it did have one then the value defined in 
the child POM should be used when rendering inherited menus in the context of 
the child's site.xml.



> Interpolation not working in inherited elements
> -----------------------------------------------
>
>                 Key: MSITE-312
>                 URL: http://jira.codehaus.org/browse/MSITE-312
>             Project: Maven 2.x Site Plugin
>          Issue Type: Bug
>          Components: inheritance
>    Affects Versions: 2.0-beta-7
>         Environment: JDK 1.5.0_13 on OS/X 10.5.2
>            Reporter: Brian Hanafee
>         Attachments: example.zip
>
>
> Properties defined in the local POM are not interpolated into elements of the 
> site that are inherited.
> In the attached example, the property "parentprop" is defined in the parent 
> POM and "childprop" is defined in the child POM. The parent project has a 
> site.xml that defines an inherited menu with items that reference both 
> properties. Only parentprop is interpolated. The child project has an 
> identical menu and the properties are interpolated correctly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to