slachiewicz opened a new pull request, #2343:
URL: https://github.com/apache/maven-resolver/pull/2343

   Follow-up cleanup to #2339.
   
   Now that Surefire creates `target/surefire-tmp`, the `// hack for Surefire` 
`mkdirs()` calls in tests are dead code — remove them (three call sites in 
`maven-resolver-impl` and `maven-resolver-named-locks-hazelcast`), including 
their now-unused `java.nio.file.Paths` imports.
   
   Also set Failsafe's `tempDir` to `failsafe-tmp` so it creates the directory 
its `java.io.tmpdir` setting points at, giving ITs the same guarantee. The 4 
Hazelcast ITs under `-Prun-its` pass with this change.
   
   Verified locally: `mvn -B -q clean test` green on JDK 8 and 21; `mvn -B -q 
-pl maven-resolver-named-locks-hazelcast -am verify -Prun-its` green; 
`spotless:check` clean.
   
   The uncommented `createDirectories` calls in `DirectoryUtilsTest` are 
deliberately left alone — drafts #2341/#2342 touch that file.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to