slachiewicz commented on PR #1273:
URL: https://github.com/apache/maven-scm/pull/1273#issuecomment-7052667868

   Pushed two commits. The first keeps the nine protected `execute*Command` 
methods (`executeAddCommand`, both `executeBranchCommand`, 
`executeEditCommand`, `executeRemoveCommand`, both `executeTagCommand`, 
`executeUnEditCommand`, `executeUntagCommand`) returning `ScmResult`, with a 
cast in each `executeCommand`: narrowing their return type changed the method 
descriptors, so providers compiled against 2.2.1 failed with 
`AbstractMethodError` on this API. The second parameterises the remaining raw 
types (`AbstractLockCommand`, `AbstractUnlockCommand`, `SvnInfoCommand`, the 
`get*Command()` methods of `GitExeScmProvider`).
   
   @michael-o: with this change japicmp (`-a protected`) reports none of the 
nine against 2.2.1, the descriptors match 2.2.1's, and 
`AbstractAddCommand`/`AbstractTagCommand` subclasses compiled against 2.2.1 run 
unchanged. It remains a source break for providers that override 
`executeCommand` with `ScmResult`, which belongs in the release notes. 
Narrowing the nine methods can wait for a major release.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to