slachiewicz opened a new issue, #3614:
URL: https://github.com/apache/maven-surefire/issues/3614

   Affected version: master at d7c7e359e.
   
   `VerifyMojo.execute` 
(maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/VerifyMojo.java:176-197)
 builds the build pass/fail decision by re-reading `summaryFile`/`summaryFiles` 
that `IntegrationTestMojo.handleSummary` wrote earlier 
(maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java:624-636).
 Only a `FAILSAFE_IN_PROGRESS` token is stored in the plugin context; the 
observed `RunResult` is not. `verifyParameters` (VerifyMojo.java:223-245) 
returns `getFailIfNoTests()`, which defaults to `false` at line 144, when the 
summary does not exist.
   
   As a result, deleting the summary file in the window between the two goals 
makes `verify` report success even though `integration-test` recorded failures. 
Replacing its content with an all-pass summary has the same effect.
   
   Expected behavior: carry the observed `RunResult` through the plugin 
context/session and treat the XML file as a human-readable artifact; at 
minimum, fail closed when a summary that the build is known to have written is 
missing. A regression test can delete the summary between the two goals and 
assert that verify fails.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to