slachiewicz opened a new issue, #3612:
URL: https://github.com/apache/maven-surefire/issues/3612

   Affected version: master at d7c7e359e.
   
   Three related observations on the fork channel session token:
   
   - `ForkStarter.java:571-573` logs the full fork-node connection string, 
including `sessionId=<uuid>`, at debug level.
   - `InvalidSessionIdException.java:34-36` includes both the supplied and the 
expected token in its message, so a mismatch puts a valid token into logs/stack 
traces.
   - `SurefireForkChannel.verifySessionId` 
(maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/extensions/SurefireForkChannel.java:188-209)
 compares the first-frame token with `String.equals` at line 202.
   
   Expected behavior: redact the `sessionId` query parameter in debug output 
and exception messages, and use a constant-time comparison such as 
`MessageDigest.isEqual` for the first-frame check. A test can assert that the 
token never appears in a captured debug log or exception message.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to